Do not refer to page in OptimizeLayerFrames #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
page dimension was used to create images to compare different disposal methods. However, functions used for the comparisons, namely CompareImagesBounds and IsBoundsCleared are based on the dimensions of images themselves. Creating image with page dimension is inefficient when converting images with larger pages and therefore should be avoided.
|
Optimizing images are based on the virtual page layout reflected in the image->page member. See the GIF image specification for details. There is likely a bug in optimizing images in some cases but replacing the virtual page with the actual image dimensions will likely break the optimization algorithm. |
|
That should not be problematic because the input is assumes coalesced. We may have assertion if not sure. |
|
We'll need a few days to test your assumptions before we can merge the pull. Stand by... |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Feb 26, 2018
* Fix broken file format detection and potentially other features
7.0.7.23 does not work at all for me.
Changelog:
2018-02-25 7.0.7-24 Cristy <quetzlzacatenango@image...>
* Release ImageMagick version 7.0.0-24, GIT revision 23079:7ccb76178:20180225.
2018-02-19 7.0.7-24 Cristy <quetzlzacatenango@image...>
* Do not refer to page in OptimizeLayerFrames (reference
ImageMagick/ImageMagick#987).
* PerlMagick unit tests pass again.
* Fixed numerous use of uninitialized values, integer overflow,
memory exceeded, and timeouts (credit to OSS Fuzz).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
page dimension was used to create images to compare different disposal methods. However, functions used for the comparisons, namely
CompareImagesBoundsandIsBoundsClearedare based on the dimensions of images themselves.Creating image with page dimension is inefficient when converting images with larger pages and therefore should be avoided.
This is what I should have done before #983. See #984 (comment).