Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

work around pillow 10.0.0 changes #244

Merged
merged 3 commits into from
Jul 26, 2023
Merged

work around pillow 10.0.0 changes #244

merged 3 commits into from
Jul 26, 2023

Conversation

CPBridge
Copy link
Collaborator

Fix for #243 :

  • Require pillow >=10.0.0
  • Update highdicom.color to use the new organisation of constants found in pillow==10.0.0

@CPBridge CPBridge requested a review from hackermd July 13, 2023 11:17
@CPBridge CPBridge self-assigned this Jul 13, 2023
@CPBridge CPBridge added the bug Something isn't working label Jul 13, 2023
@CPBridge
Copy link
Collaborator Author

ok so it appears that pillow 10.0.0 does not support python 3.7. This is going to be mmore complex that I had thought. We will have to either drop support for 3.7 or put some hacks in place that can deal with both pillow<10.0.0 and pillow>=10.0.0. I am reluctant to drop support for 3.7 personally, as it is still in widespread use

@CPBridge
Copy link
Collaborator Author

OK so this is ugly but I added logic that works around the breaking change at pillow 10.0.0 so that we can continue to support python 3.7. While this doesn't smell great, in my opinion, it is worth it to avoid dropping an entire version of python just to avoid this tiny little API change. I note that over the last 6 months around 5-10% of our users are using 3.7: https://pypistats.org/packages/highdicom. What do you think @hackermd ?

@CPBridge CPBridge changed the title Require pillow>=10.0.0, fix accordingly work around pillow 10.0.0 changed Jul 13, 2023
@CPBridge CPBridge changed the title work around pillow 10.0.0 changed work around pillow 10.0.0 changes Jul 13, 2023
@CPBridge CPBridge merged commit f453e78 into master Jul 26, 2023
11 checks passed
@CPBridge CPBridge deleted the bug/pillow_10.0.0 branch June 27, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants