Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some attributes for customize this View #20

Merged
merged 7 commits into from Aug 13, 2018

Conversation

LiuShuaiQ
Copy link
Contributor

I think this attibutes may be used.
angleRange attributes - the angle range, the default value is 360.
showClickAnim attributes - this switch of click animation.
centerButtonGravity attributes - for set Gravity for centerButton, the default value is CENTER.

@ImangazalievM
Copy link
Owner

ImangazalievM commented Aug 10, 2018

Hello! Good job! But can you give examples of cases where we can use centerButtonGravity and showClickAnim attributes, please?

I guess showClickAnim implementation has a bug. When I use this attribute with false value, the menu does not close on a button click.

@LiuShuaiQ
Copy link
Contributor Author

LiuShuaiQ commented Aug 13, 2018

Yes, showClickAnim implementation indeed has a bug. When this attribute with false value, the OnItemClickListener does not callback! But I think close the menu should be placed inside the OnItemClickListener, the click behavior is determined by the developer.

Now I fixed this bug, and update sample code for this.

@ImangazalievM ImangazalievM merged commit cb71f0e into ImangazalievM:master Aug 13, 2018
@ImangazalievM
Copy link
Owner

ImangazalievM commented Aug 13, 2018

@LiuShuaiQ Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants