Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add true durability #1011

Closed
Infernopickaxe opened this issue Mar 21, 2019 · 11 comments
Closed

Add true durability #1011

Infernopickaxe opened this issue Mar 21, 2019 · 11 comments
Assignees
Labels
GUI The issue is related to the GUI's in Impact Suggestion The issue is a suggestion of a feature being added to the official Impact build
Milestone

Comments

@Infernopickaxe
Copy link

Infernopickaxe commented Mar 21, 2019

For armor and tools that go above the normal durability amount as in 2b2t's "unbreakables" (not really unbreakable)
I would like it if it displays in the armor hud, hovering over the item, and seeing it in player name tags
(I believe the items have a high negative damage value)

@LeafHacker
Copy link
Contributor

LeafHacker commented Mar 21, 2019

Minecraft doesn't support modifying the durability of a tool, so the concept of a higher durability tool doesn't make sense.

Instead items have a damage value which counts up until maxDamage is reached and the item is destroyed.

I suspect that maybe you are talking about enchantments, perhaps the item has a high level Unbreaking enchantment or something?

@Infernopickaxe
Copy link
Author

Infernopickaxe commented Mar 21, 2019

No I'm talking about durability
Another client already has true durability
On 2b2t we have "unbreakables" the durability of these items are in the thousands (max being the original durability + 32767)
(The lowest durability possible is -32767 + the original durability of the item)

@LeafHacker
Copy link
Contributor

LeafHacker commented Mar 21, 2019

That doesn't make sense. The -32,768 to +32,767 is a 16bit short, which enchantment levels are stored as. However damage and maxDamage are both stored as 32bit ints which has a range of -2,147,483,648 to +2,147,483,647 ("durability" remaining is calculated on the fly as maxDamage - damage).

I'd love to see a screenshot/gif/video/whatever of one of these items, or a /give command of how they were originally hacked in (and in which version).

@Infernopickaxe
Copy link
Author

Infernopickaxe commented Mar 21, 2019

Do you have a discord?

@LeafHacker
Copy link
Contributor

LeafHacker commented Mar 21, 2019

Yes, here. Btw this probably a duplicate of #957

@Infernopickaxe
Copy link
Author

Infernopickaxe commented Mar 21, 2019

Yeah I just joined in github I didnt see that one

@LeafHacker
Copy link
Contributor

LeafHacker commented Mar 21, 2019

np it wouldn't have been easy to find since damage/durability isn't in the title. Anyway back on topic do you have anything showing the characteristics of these items? Have you interacted with these yourself or simply heard about them somewhere (if so where)?

@Infernopickaxe
Copy link
Author

Infernopickaxe commented Mar 21, 2019

Trying to find the screenshot

@Infernopickaxe
Copy link
Author

Infernopickaxe commented Mar 21, 2019

image
Add an extra line on the tooltip similar to this for damage information

@LeafHacker
Copy link
Contributor

LeafHacker commented Mar 21, 2019

I don't think this adds anything that the vanilla game doesn't already do. Vanilla already shows Durability: 3204/1561, the only thing added in the screenshot is the damage (-1643) which is - durability + maxDamage (since durability = maxDamage - damage)

@leijurv leijurv self-assigned this Mar 22, 2019
@leijurv leijurv added Suggestion The issue is a suggestion of a feature being added to the official Impact build GUI The issue is related to the GUI's in Impact labels Mar 22, 2019
@leijurv leijurv added this to the 4.6 milestone Mar 22, 2019
@leijurv
Copy link
Member

leijurv commented Mar 22, 2019

Added in 4.6 - vanilla doesn't show the durability if damage is negative, so we added an option to make it always show.

@leijurv leijurv closed this as completed Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI The issue is related to the GUI's in Impact Suggestion The issue is a suggestion of a feature being added to the official Impact build
Projects
None yet
Development

No branches or pull requests

3 participants