Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jesus failing when walking on Kelp #1063

Open
blockparole opened this issue Apr 2, 2019 · 6 comments
Assignees
Labels
Bug
Projects
Milestone

Comments

@blockparole
Copy link

@blockparole blockparole commented Apr 2, 2019

When walking over Kelp in Water, the Player sinks down about 0.6 deep in the Water Block.

Version: Impact 4.6 1.13.2

@ZeroMemes ZeroMemes added the Bug label Apr 2, 2019
@ZeroMemes

This comment has been minimized.

Copy link
Member

@ZeroMemes ZeroMemes commented Apr 2, 2019

This really applies to all waterlogged blocks, we are only modifying the bounding box of true water blocks right now.

@LeafHacker

This comment has been minimized.

Copy link
Contributor

@LeafHacker LeafHacker commented Apr 4, 2019

Bread man did some work on this in ImpactDevelopment/Impact@d40278c

@LeafHacker

This comment has been minimized.

Copy link
Contributor

@LeafHacker LeafHacker commented Apr 9, 2019

Is this fixed or is there more to be done? Maybe a checklist should be added to reflect progress?

@ZeroMemes ZeroMemes added this to the 4.7 milestone Apr 9, 2019
@ZeroMemes

This comment has been minimized.

Copy link
Member

@ZeroMemes ZeroMemes commented Apr 9, 2019

As Leaf referenced, this should be improved in the latest patch. There is still more to be done, ideally all waterlogged blocks would have a solid water state.

@LeafHacker LeafHacker added this to Low priority in Impact Bugs May 24, 2019
@VirxEC

This comment has been minimized.

Copy link

@VirxEC VirxEC commented Jun 21, 2019

Can confirm that it doesn't work on seagrass either

@ZeroMemes ZeroMemes modified the milestones: 4.7, LONG_TERM Jul 12, 2019
@ZeroMemes

This comment has been minimized.

Copy link
Member

@ZeroMemes ZeroMemes commented Jul 12, 2019

I haven't found a nice way to do this, and functionality isn't completely inhibited, moving to LONG_TERM

@leijurv leijurv modified the milestones: LONG_TERM, 4.7 Jul 16, 2019
@ZeroMemes ZeroMemes modified the milestones: 4.7, 4.8 Sep 9, 2019
@ZeroMemes ZeroMemes modified the milestones: 4.8, 4.9 Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Impact Bugs
  
Low priority
5 participants
You can’t perform that action at this time.