Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potion Effects icons in the top right corner are invisible #1064

Closed
1butler1 opened this issue Apr 2, 2019 · 3 comments
Labels
Bug

Comments

@1butler1
Copy link

@1butler1 1butler1 commented Apr 2, 2019

What happens?

The potion effects are not visible in the upper right hand corner, therefor creating a space above the module list, if you have any potion effects.

1.13.2: http://i.imgur.com/z2VbT7w.png
1.12.2: http://i.imgur.com/VQxWZn6.png

Exact steps to reproduce?

  • Join a server/singleplayer world in which you have potion effects
  • You won't see the potion effects in the corner and there's about a half inch gap above your module list in the HUD
Additional Client Info
  • Impact Version: 4.6 for 1.13.2
  • Using Optifine? Yes
  • Using LiteLoader? No
  • Enabled mods: Hud, StorageESP, Nametags, AutoTool, Light
  • Operating System: Windows 10 64-bit
@LeafHacker

This comment has been minimized.

Copy link
Contributor

@LeafHacker LeafHacker commented Apr 2, 2019

The gap is intended*, the bug is that the effect icons aren't rendered for some reason.

* We make a gap whenever the player has any effects active so that the HUD doesn't draw over the icons.

@LeafHacker LeafHacker changed the title Potion Effects are not visible/replaced by a space above module list Potion Effects icons in the top right corner are invisible Apr 2, 2019
@LeafHacker LeafHacker added the Bug label Apr 2, 2019
@1butler1

This comment has been minimized.

Copy link
Author

@1butler1 1butler1 commented Apr 2, 2019

Yeah I figured that, the gap just looks ugly without the rendered icons.

@ZeroMemes

This comment has been minimized.

Copy link
Member

@ZeroMemes ZeroMemes commented Apr 2, 2019

Found the issue. While the method we were using before, doesShowParticles, exists in 1.13.2, it is no longer used in the code for rendering the potion effect icons. Rather, isShowIcon is used. This has been fixed in the upcoming patch for 4.6.

@ZeroMemes ZeroMemes closed this Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.