Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsed links in the MOTD dont actually work #1151

Closed
zPeanut opened this issue Apr 19, 2019 · 5 comments
Labels
Projects
Milestone

Comments

@zPeanut
Copy link
Member

@zPeanut zPeanut commented Apr 19, 2019

tested on Impact 4.6 for 1.13.2, 19th April 2019

@zPeanut zPeanut added Bug GUI labels Apr 19, 2019
@zPeanut zPeanut added the Critical label Apr 29, 2019
@LeafHacker

This comment has been minimized.

Copy link
Contributor

@LeafHacker LeafHacker commented May 12, 2019

This is caused by AWT reporting that the Desktop class isn't supported because GraphicsEnvironment.isHeadless() returns true.

I suspect this is because of a change in GLFW, but that is pure speculation.

Relevant code here @ImpactDevelopment/impact-developer.

@LeafHacker

This comment has been minimized.

Copy link
Contributor

@LeafHacker LeafHacker commented May 12, 2019

This should affect all Desktop stuff, including opening the file browser and web links from the Impact menu

@0-x-2-2

This comment has been minimized.

Copy link
Contributor

@0-x-2-2 0-x-2-2 commented May 12, 2019

this is because of a hack for lwjgl 3 glfw to not break fully on mac if a awt class is loaded

@LeafHacker

This comment has been minimized.

Copy link
Contributor

@LeafHacker LeafHacker commented May 16, 2019

We can probably do the Desktop stuff in a new (headed) thread then, if minecraft has decided it wants to be headless...

@LeafHacker LeafHacker added this to High priority in Impact Bugs May 24, 2019
@leijurv leijurv added this to the 4.7 milestone May 29, 2019
@leijurv leijurv closed this May 29, 2019
Impact Bugs automation moved this from High priority to Closed May 29, 2019
@leijurv

This comment has been minimized.

Copy link
Member

@leijurv leijurv commented May 29, 2019

Fixed in 4.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Impact Bugs
  
Closed
4 participants
You can’t perform that action at this time.