Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange behavior with Riding + Jesus #1233

Closed
leijurv opened this issue May 30, 2019 · 2 comments
Assignees
Labels
Bug
Milestone

Comments

@leijurv
Copy link
Member

@leijurv leijurv commented May 30, 2019

Describe the bug
Horses bounce and don't stand entirely on top of water IF the player is standing on land not water while mounting the horse. It doesn't matter where the horse is standing.

To Reproduce
Steps to reproduce the behavior:

  1. Have Riding enabled, including Swim. Have Jesus enabled.
  2. Mount a horse while standing on land
  3. The horse bobs in the water and doesn't walk on top of it. Toggling any of these modules doesn't change this (except obviously turning off Swim in Riding causes you to dismount due to drowning).
    --
  4. Having Riding enabled, including Swim. Have Jesus enabled.
  5. Mount a horse while standing on water
  6. The horse walks on water. This continues to work even if you go onto land then back onto water, or if you jump, or anything.

Expected behavior
Regardless of the circumstances of mounting the horse, it walks on water.

Video
https://youtu.be/JMGu56-5KXc

Game output

Crash report

Additional Client Info
  • Impact Version: 4.6 for 1.12.2
  • Using Optifine? Yes
  • Using LiteLoader? No
  • Enabled mods:
  • Operating System:
@leijurv leijurv added the Bug label May 30, 2019
@leijurv leijurv added this to the 4.7 milestone May 30, 2019
@leijurv

This comment has been minimized.

Copy link
Member Author

@leijurv leijurv commented May 30, 2019

@ZeroMemes JesusSolid updates according to MotionUpdateEvent and sets isLiquidSolid. When you're riding a horse, MotionUpdateEvent doesn't fire. So that does explain this, in how the water is only solid if you were standing on it right before getting on the horse. I'm not sure the best way to fix tho?

@ZeroMemes

This comment has been minimized.

Copy link
Member

@ZeroMemes ZeroMemes commented Jul 15, 2019

Fixed in 4.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.