Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breadcrumbs height calculation on snow covered blocks #1280

Closed
a6d6061ed1 opened this issue Jun 11, 2019 · 6 comments
Labels
Milestone

Comments

@a6d6061ed1
Copy link

@a6d6061ed1 a6d6061ed1 commented Jun 11, 2019

Describe the bug
Breadcrumbs render height is too low on snow covered blocks.

To Reproduce
Steps to reproduce the behavior:

  1. enable render->breadcrumbs (without walls)
  2. walk on snow covered blocks

Expected behavior
Breadcrumbs should appear visibly (above snow)

Video
https://streamable.com/ftv70

Setup

  • Impact Version: 4.6 for 1.12.2
  • Using Optifine? Yes
  • Using LiteLoader? No
  • Enabled mods: click
  • Operating System: Win 10 Pro x64 1903

Additional context
I do realize that one can use walls option to make it visible. But snow is not wall. Also this problem makes breadcrumbs (without walls) useless on snowy terrain assuming you are walking on the ground.

@a6d6061ed1 a6d6061ed1 added the Bug label Jun 11, 2019
@Cerbiac

This comment has been minimized.

Copy link

@Cerbiac Cerbiac commented Jun 11, 2019

You sink into 1/16 of a block. That's just how snow blocks work. ;-;

@leijurv

This comment has been minimized.

Copy link
Member

@leijurv leijurv commented Jun 12, 2019

As a workaround, try adding another layer of snow or two to that biome. I think you start standing on top of it at layer 2 or 3. You'll be able to see your breadcrumbs just fine then 👍

@leijurv leijurv added the GUI label Jun 12, 2019
@Cerbiac

This comment has been minimized.

Copy link

@Cerbiac Cerbiac commented Jun 12, 2019

@leijurv You always sink 1/16 (or 1 layer) into snow layers, no matter the actual height. I.e. 3 layers (3/16) means you'll walk 2/16 meters up. This also means adding all 16 layers may look like a full snow block, but isn't.

@ZeroMemes

This comment has been minimized.

Copy link
Member

@ZeroMemes ZeroMemes commented Jun 16, 2019

I suppose the way that breadcrumbs would gauge where to record the player's position could be offset by the max height of whatever block they are currently standing in, given it's not air?

@leijurv

This comment has been minimized.

Copy link
Member

@leijurv leijurv commented Jun 17, 2019

well we dont really want the max height, we want the difference between rendered height and collided height I guess?

is there any block except snow thats like this...?

oh soul sand

so we could do some cancer with operating on voxel shapes.......... orrrrrrrrrr we could pull a gooooood ol' +0.1251

@leijurv leijurv added this to the 4.7 milestone Jun 17, 2019
@leijurv leijurv closed this Jun 21, 2019
@leijurv

This comment has been minimized.

Copy link
Member

@leijurv leijurv commented Jun 21, 2019

Added in 4.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.