Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executing Baritone's "damn" command runs fine, but causes Impact to output an invalid syntax warning. #842

Closed
SylveonBottle opened this issue Oct 28, 2018 · 6 comments
Milestone

Comments

@ZeroMemes

This comment has been minimized.

Copy link
Member

@ZeroMemes ZeroMemes commented Oct 28, 2018

LOL

1 similar comment
@leijurv

This comment has been minimized.

Copy link
Member

@leijurv leijurv commented Oct 28, 2018

LOL

@ZeroMemes ZeroMemes added the Bug label Oct 28, 2018
@leijurv leijurv added the Baritone label Oct 28, 2018
@SuperOP535

This comment has been minimized.

Copy link
Contributor

@SuperOP535 SuperOP535 commented Oct 30, 2018

BIGGEST BUG NEEDS TO BE SOLVED NOW

@leijurv

This comment has been minimized.

Copy link
Member

@leijurv leijurv commented Nov 1, 2018

This is so that you can still say damn in chat on baritone standalone (with no prefix). (i.e. it's intended behavior that saying damn in baritone standalone gets passed through to chat, AND baritone also responds to it with daniel) Therefore, this is a wontfix from the baritone side, but Impact could still detect the damn message and not print the invalid syntax message even though ExampleBaritoneControl returns false.

@leijurv leijurv added the Critical label Feb 24, 2019
@leijurv leijurv added this to the 4.5 milestone Feb 24, 2019
@ZeroMemes

This comment has been minimized.

Copy link
Member

@ZeroMemes ZeroMemes commented Feb 24, 2019

Go away

@ZeroMemes ZeroMemes modified the milestones: 4.5, Upcoming Feb 24, 2019
@leijurv

This comment has been minimized.

Copy link
Member

@leijurv leijurv commented Feb 25, 2019

Fixed in 4.6

@leijurv leijurv closed this Feb 25, 2019
@leijurv leijurv modified the milestones: 4.6, 4.5 Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.