Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Murder Mystery Hypixel not detecting murderer #861

Closed
ghost opened this issue Nov 10, 2018 · 4 comments
Labels
Bug
Milestone

Comments

@ghost
Copy link

@ghost ghost commented Nov 10, 2018

What happens?

Hypixel Murder Mystery ESP does not detect someone as murderer if they hold a cookie.

Exact steps to reproduce?

  • Turn on the murder module with hypixel mode on hypixel.net
  • Have a murderer hold a cookie as their sword
  • They won't be detected as murderer

Maybe have it so that if anyone holds anything but a bow, arrow, map, or gold, mark them as murderer to support future sword type updates.

Additional client info
  • Impact Version: 4.4 for 1.12.2
  • Using Optifine? No
  • Using LiteLoader? No
  • Enabled mods: Murder (Hypixel)
  • Operating System: Windows 10 64 bit
@MightyKnight MightyKnight added the Bug label Nov 10, 2018
@MightyKnight

This comment has been minimized.

Copy link

@MightyKnight MightyKnight commented Nov 10, 2018

Related to #567.
I like your idea, but it has the same flaws as the current implementation.
Non-murderer items get updated too, sometimes with new maps. Currently there are:

  • Bow, arrow
  • Gold ingot
  • Map
  • Wood shovel, snowball
  • String

Here's the dilemma:

  1. Either detect for items the murderer can hold -> If Hypixel updates murderer is not shown
  2. Or detect for items except the ones innocents can hold -> If Hypixel updates false murderers are shown
@LeafHacker

This comment has been minimized.

Copy link
Contributor

@LeafHacker LeafHacker commented Nov 10, 2018

I suppose we could find some kind of middle ground by highlighting players holding items we didn't expect either class to hold, but I'm not too keen on that as it promotes us ignoring changes to items.

A better solution might be to store the items in JSON on the resources repo, so they can be updated without having to update Impact.

Either way that's probably a separate issue as this issue is primarily discussing cookies not being recognised as murderers.

@ZeroMemes

This comment has been minimized.

Copy link
Member

@ZeroMemes ZeroMemes commented Jun 25, 2019

I'll keep the fix with this issue, and create a new issue for a json on the resources repo.

@ZeroMemes ZeroMemes closed this Jun 25, 2019
@ZeroMemes ZeroMemes added this to the 4.7 milestone Jun 25, 2019
@tyuop077

This comment has been minimized.

Copy link

@tyuop077 tyuop077 commented Jul 24, 2019

@LeafHacker @leijurv @ZeroMemes

List of murder's items:
iron_sword
stone_sword
iron_shovel
stick
wooden_axe
wooden_sword
stone_shovel
blaze_rod
diamond_shovel
feather
pumpkin_pie
golden_pickaxe
carrot_on_a_stick
bone
carrot
golden_carrot
cookie
diamond_axe
golden_sword
diamond_sword
diamond_hoe
shears
fish:1

Murder's Items Page 1
Murder's Items Page 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.