New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra metadata types property and itemprop #109

Closed
fiammybe opened this Issue Jun 30, 2017 · 1 comment

Comments

Projects
2 participants
@fiammybe
Copy link
Member

fiammybe commented Jun 30, 2017

At this moment, it is impossible to generate Facebook Open Graph metadata or Google+ metadata, because we need to generate the following meta tags :

<!-- Schema.org markup for Google+ -->
<meta itemprop="name" content="ImpressCMS">

<!-- Open Graph data -->
<meta property="og:locale" content="<{$icms_langcode}>" />

For that, we'll need to add the metadata types property and itemprop

@fiammybe fiammybe added this to the v1.3.11 milestone Jun 30, 2017

@fiammybe fiammybe self-assigned this Jun 30, 2017

@fiammybe fiammybe added this to New in v1.3.11 Jun 30, 2017

fiammybe pushed a commit to fiammybe/impresscms that referenced this issue Jun 30, 2017

@MekDrop

This comment has been minimized.

Copy link
Member

MekDrop commented Jul 3, 2017

I think this is related to SEO functionality and because SEO needs always changes maybe would be a better idea to use integrated library like https://github.com/ARCANEDEV/SEO-Helper But from other side i'm not sure if that doesn't requires much more work and that's why maybe the way how you are solving this is better for now... I don't see there anything bad but i'm not sure how much can be this useful for us in the future :/

@fiammybe fiammybe closed this Oct 6, 2017

@fiammybe fiammybe removed this from the v1.3.11 milestone Mar 19, 2018

@fiammybe fiammybe added this to the v1.3.11 milestone Apr 26, 2018

@fiammybe fiammybe moved this from New to Done in v1.3.11 Jun 7, 2018

fiammybe added a commit to fiammybe/impresscms that referenced this issue Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment