Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Protector for PHP7 #492

Merged

Conversation

@skenow
Copy link
Contributor

skenow commented Sep 23, 2019

Close #481

install completes on PHP7, module functions on PHP5.6+
Still need to adjust module version

@todo

This comment has been minimized.

Copy link

todo bot commented Sep 23, 2019

-D

global $ret ; // TODO :-D
if( ! is_array( $ret ) ) $ret = array() ;
$db = icms_db_Factory::instance() ;


This comment was generated by todo based on a TODO comment in 59b3dd8 in #492. cc @skenow.
@todo

This comment has been minimized.

Copy link

todo bot commented Sep 23, 2019

-D

global $ret ; // TODO :-D
if( ! is_array( $ret ) ) $ret = array() ;
$db = icms_db_Factory::instance() ;
$mid = $module->getVar('mid') ;


This comment was generated by todo based on a TODO comment in 59b3dd8 in #492. cc @skenow.
@todo

This comment has been minimized.

Copy link

todo bot commented Sep 23, 2019

-D

global $msgs ; // TODO :-D
if( ! is_array( $msgs ) ) $msgs = array() ;
$db = icms_db_Factory::instance() ;
$mid = $module->getVar('mid') ;


This comment was generated by todo based on a TODO comment in 59b3dd8 in #492. cc @skenow.
@skenow skenow requested review from fiammybe and MekDrop Sep 23, 2019
@skenow skenow added this to the 1.4.0 milestone Sep 23, 2019
@skenow skenow added this to In progress in v1.4.x via automation Sep 23, 2019
@skenow skenow added the PHP7 label Sep 23, 2019
@fiammybe fiammybe merged commit b916053 into ImpressCMS:branches/impresscms_1.4 Sep 26, 2019
2 checks passed
2 checks passed
AccessLint Review complete
WIP Ready for review
Details
v1.4.x automation moved this from In progress to Done Sep 26, 2019
@todo todo bot mentioned this pull request Sep 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v1.4.x
  
Done
2 participants
You can’t perform that action at this time.