Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the template handling in the system module #503

Merged

Conversation

@fiammybe
Copy link
Member

fiammybe commented Oct 8, 2019

The template handling in hte system module didn't work correctly, in such a way that overriding them using a theme was not working for most of hte pages.
This should fix the problem

Copy link

accesslint bot left a comment

There are accessibility issues in these changes.

@MekDrop MekDrop added this to In progress in v1.4.x via automation Oct 8, 2019
@MekDrop MekDrop added the bug label Oct 8, 2019
@MekDrop MekDrop added this to the 1.4.0 milestone Oct 8, 2019
@MekDrop
MekDrop approved these changes Oct 8, 2019
Copy link
Member

MekDrop left a comment

I'm not sure how paths for our templates really works if there is some consequences for your changes... but I can't think anything bad about your changes right now, so - OK - Accept!

@MekDrop MekDrop merged commit 112f551 into ImpressCMS:branches/impresscms_1.4 Oct 9, 2019
2 checks passed
2 checks passed
AccessLint Found 2 issues
WIP Ready for review
Details
v1.4.x automation moved this from In progress to Done Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v1.4.x
  
Done
2 participants
You can’t perform that action at this time.