Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make expiration header dynamic in the past #504

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@fiammybe
Copy link
Member

fiammybe commented Oct 8, 2019

Believe it or not, but Chrome didn't like the date to be too far in the past. Now the login works as expected in Chrome and the Chromium-based Edge.

Fix #100

Believe it or not, but Chrome didn't like the date to be too far in the past. Now the login works as expected in Chrome and the Chromium-based Edge.
@fiammybe fiammybe added the bug label Oct 8, 2019
@fiammybe fiammybe added this to the 1.4.0 milestone Oct 8, 2019
@fiammybe fiammybe requested review from MekDrop and skenow Oct 8, 2019
@fiammybe fiammybe added this to In progress in v1.4.x via automation Oct 8, 2019
@MekDrop
MekDrop approved these changes Oct 8, 2019
@MekDrop MekDrop merged commit 794b338 into branches/impresscms_1.4 Oct 9, 2019
3 checks passed
3 checks passed
WhiteSource Security Check Security Report
Details
AccessLint Review complete
WIP Ready for review
Details
v1.4.x automation moved this from In progress to Done Oct 9, 2019
@MekDrop MekDrop deleted the fiammybe-fix-chrome-login branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v1.4.x
  
Done
2 participants
You can’t perform that action at this time.