Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks referers with HTTP middleware instead of security class #719

Merged
merged 12 commits into from Nov 11, 2020
Merged

Checks referers with HTTP middleware instead of security class #719

merged 12 commits into from Nov 11, 2020

Conversation

MekDrop
Copy link
Member

@MekDrop MekDrop commented Aug 1, 2020

Now referrer spam detection is based on https://github.com/matomo-org/referrer-spam-list library with https://github.com/middlewares/referrer-spam So in theoretically now users for such kind attack will be protected a bit better.

Also, this lets as use referer spam checking in PSR way instead our old.

Warning: This pull request is based on #707 so that one needs to be merged first.

@MekDrop MekDrop added this to the 2.0.0 Beta 1 milestone Aug 1, 2020
@MekDrop MekDrop requested review from skenow and fiammybe August 1, 2020 20:18
@MekDrop MekDrop added this to In progress in ImpressCMS 2.0 via automation Aug 1, 2020
@ImpressCMS ImpressCMS deleted a comment from todo bot Aug 1, 2020
@MekDrop MekDrop moved this from In progress to Review in progress in ImpressCMS 2.0 Aug 6, 2020
@todo
Copy link

todo bot commented Aug 20, 2020

Remove these lines once possible

* @todo Remove these lines once possible
*/
global $icmsModule;
icms::$module = &$module;
$icmsModule = &$module;


This comment was generated by todo based on a todo comment in f3986bb in #719. cc @MekDrop.

ImpressCMS 2.0 automation moved this from Review in progress to Reviewer approved Nov 11, 2020
@fiammybe fiammybe merged commit db807f9 into ImpressCMS:master Nov 11, 2020
ImpressCMS 2.0 automation moved this from Reviewer approved to Done Nov 11, 2020
@MekDrop MekDrop deleted the improvement/check-referers-from-middleware branch November 11, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants