New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checks referers with HTTP middleware instead of security class #719
Merged
fiammybe
merged 12 commits into
ImpressCMS:master
from
MekDrop:improvement/check-referers-from-middleware
Nov 11, 2020
Merged
Checks referers with HTTP middleware instead of security class #719
fiammybe
merged 12 commits into
ImpressCMS:master
from
MekDrop:improvement/check-referers-from-middleware
Nov 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l support for all routes
…erers-from-middleware
…ck-referers-from-middleware
Remove these lines once possibleimpresscms/core/Middlewares/DetectModuleMiddleware.php Lines 56 to 61 in f3986bb
This comment was generated by todo based on a
|
…erers-from-middleware
…erers-from-middleware
…erers-from-middleware
…erers-from-middleware
…erers-from-middleware
fiammybe
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now referrer spam detection is based on https://github.com/matomo-org/referrer-spam-list library with https://github.com/middlewares/referrer-spam So in theoretically now users for such kind attack will be protected a bit better.
Also, this lets as use referer spam checking in PSR way instead our old.
Warning: This pull request is based on #707 so that one needs to be merged first.