New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use commonjs as the webpack library target. #19

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@lexicalunit
Collaborator

lexicalunit commented Dec 6, 2018

No description provided.

@lexicalunit lexicalunit requested a review from jportela Dec 6, 2018

@littlebee

Looks good to me ! Just curious, how did it work with a default of var? I guess there is a change needed to the plugin loader too?
:tmyk: 🌈 🦄

@littlebee

This comment has been minimized.

Contributor

littlebee commented Dec 7, 2018

I merged my earlier change, but I haven't published a new version to npm yet. I'm not sure if I even have permission to publish. If you want to do it after this merge, go for it.

@littlebee

This comment has been minimized.

Contributor

littlebee commented Dec 7, 2018

Oh, also noticed we have a security vulnerability warning from github. I looked into it briefly, but didn't understand it. It seems to be saying that package-lock.json is itself a security risk, but I don't see why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment