[DEV-5635] ADD: pagination to client #90
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pastap
force-pushed
the
astha/paginator
branch
from
e197ff5 to
22801fd
Compare
pastap
force-pushed
the
astha/paginator
branch
from
22801fd to
970e8f7
Compare
nkassis
reviewed
Feb 23, 2021
| submission_ids = client.call( | ||
| WorkflowSubmission(workflow_id=wf.id, files=[dataset_filepath]*5) | ||
| ) | ||
| for sub in client.paginate(ListSubmissions(workflow_ids=[wf.id], limit=3)): |
Contributor
There was a problem hiding this comment.
If we pass a limit of 3 we should get 3 back, if they don't pass this limit we should pass one or use the server default.
| elif request and isinstance(request, HTTPRequest): | ||
| return self._http.execute_request(request) | ||
|
|
||
| def paginate(self, request: PagedRequest): |
Contributor
There was a problem hiding this comment.
I don't think we need this function, PageRequest can encapsulate this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically creates a generator for users to loop through pages for List<> queries. Implemented on ListSubmissions since that was the ask from clients (and I don't think any other query will exceed 1000 items, tbh)
Atm, only supports going forwards - don't see a need yet to support stuff like "before" and so on