Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hub-config.md #105

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Update hub-config.md #105

merged 1 commit into from
Apr 1, 2024

Conversation

mmkerr
Copy link
Contributor

@mmkerr mmkerr commented Apr 1, 2024

Address issue number #64 (#64).

@bsweger bsweger self-requested a review April 1, 2024 18:19
@bsweger
Copy link
Contributor

bsweger commented Apr 1, 2024

Your changes look good @mmkerr. I'm a little curious that the README for this repo states:

Note that PRs should trigger preview builds of the site, so you should be able to double-check that your changes look as expected.

And I didn't see anything preview-related on the PR. That said, I checked the updates by cloning your fork and building the site on my laptop.

I also saw that the links to our latest hubverse schema are broken 😱 (which is not related to your changes, pretty sure I did that--will create an issue), so thanks for inadvertently surfacing that problem!

@nickreich
Copy link
Contributor

The link to the preview is there, under the "Details" link shown in the bottom right below:
image

@bsweger
Copy link
Contributor

bsweger commented Apr 1, 2024

This is what I see (no preview) 🤔

Screenshot 2024-04-01 at 2 28 29 PM

@mmkerr mmkerr merged commit 1dc72c1 into hubverse-org:main Apr 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants