[Surprise Exam] Fix headgear and melee armor puzzles (#28) #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Track the card matching puzzle hint with `patternCardHint` instead of a local variable - Add logging for the card matching puzzle hint to the `exportexampuzzle` chat command within onCommandExecuted
- Update existing enums within RelationshipType and add new MELEE_GEAR type - Added new keywords for PIRATE_THEME, ENTERTAINMENT_THEME, and HEAD_ARMOR (fixes #28 headgear hint) - Added new type MELEE_GEAR to resolve (fixes #28 next missing melee gear item) - Add new relationship within OSRSItemRelationshipSystem for MELEE_GEAR (fixes #28 next missing melee gear item) - Remove extra newline within RandomEventItem - Add additional RelationshipSystem tests (#28)
- Added card matching puzzle hint to the export command - Updated various RelationshipType keywords - Added new RelationshipType.MELEE_GEAR - Updated plugin to v2.5.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two incorrect Surprise Exam puzzles (#28):
Additionally, it adds to the
::exportexampuzzlecommand by now exporting the matching puzzle hint which was missing.feat(surpriseexam): Add card matching hint to export command
patternCardHintinstead of a local variableexportexampuzzlechat command within onCommandExecutedfeat(surpriseexam): Update RelationshipType, add MELEE_GEAR type (#28)
chore: Update plugin to v2.5.7 (#28)