add soln to ch1 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrom911
approved these changes
Oct 7, 2021
src/Chapter1.hs
Outdated
| @@ -568,7 +573,8 @@ True | |||
| >>> isVowel 'x' | |||
| False | |||
| -} | |||
| isVowel c = error "isVowel: not implemented!" | |||
| isVowel :: Char -> Bool | |||
| isVowel c = c `elem` ['a', 'e', 'i', 'o', 'u'] | |||
There was a problem hiding this comment.
Nice one! 👍🏼
One note in here, that sometimes, elem could be slower than the explicit pattern matching. I remember there were some benchmarks on one particular case, that showed how moving to pattern matching on each case separately drastically decrease time 🐎
src/Chapter1.hs
Outdated
Comment on lines
667
to
668
| | mod n 10 == n = n | ||
| | otherwise = firstDigit $ div n 10 |
There was a problem hiding this comment.
I see, that for negative numbers this implementation will not give a correct result.
However, this is easy to fix with your solution 👍🏼
There was a problem hiding this comment.
I see. I thought all tests were passing since nothing was showing in red while in fact, this was leading to an infinite loop 😅
vrom911
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solutions for Chapter 1
cc @vrom911 @chshersh