Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mock environ in test_find_api_key so it passes when SUPERSTAQ_API_KEY is set locally #419

Merged
merged 3 commits into from
Mar 28, 2023

Conversation

richrines1
Copy link
Contributor

previously the part of the test which was supposed to read the key from a file would fail because the env variable took precedence

@richrines1 richrines1 requested a review from a team as a code owner March 28, 2023 05:19
@richrines1 richrines1 requested review from dowusu-antwi and removed request for a team March 28, 2023 05:19
Copy link
Contributor

@dowusu-antwi dowusu-antwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@perlinm
Copy link
Collaborator

perlinm commented Mar 28, 2023

Thanks for catching (and fixing) this @richrines1!

@dowusu-antwi
Copy link
Contributor

FYI there's an issue with IonQ's device causing the notebook check failure:
image

@richrines1 richrines1 merged commit b9d62ec into main Mar 28, 2023
@richrines1 richrines1 deleted the find-token-clear-env branch March 28, 2023 16:23
bharat-thotakura pushed a commit that referenced this pull request Apr 10, 2023
…EY is set locally (#419)

previously the part of the test which was supposed to read the key from
a file would fail because the env variable took precedence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants