Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Attributes Inspector] Hotkeys doesn't work on Firefox 25.0a1 #12

Closed
Infocatcher opened this issue Jul 27, 2013 · 2 comments

Comments

Projects
None yet
1 participant
@Infocatcher
Copy link
Owner

commented Jul 27, 2013

Seems like after preventDefault() call for "keydown" "keypress" event doesn't happens at all.

Infocatcher added a commit that referenced this issue Jul 27, 2013

@Infocatcher

This comment has been minimized.

Copy link
Owner Author

commented Aug 15, 2013

Successfully tested on Firefox 26.0a1 (2013-08-14).

@Infocatcher

This comment has been minimized.

Copy link
Owner Author

commented Aug 19, 2013

Infocatcher added a commit that referenced this issue Nov 1, 2013

Infocatcher added a commit that referenced this issue Jul 28, 2017

Fix hotkeys in Pale Moon
// See #12
// keydown  => stopEvent() + hetkey action in Firefox >= 25
// keypress => stopEvent() + hetkey action in Firefox < 25
// keyup    => stopEvent()
var onlyStop = this.fxVersion < 25
	? e.type == "keydown" || e.type == "keyup"
	: e.type == "keypress" || e.type == "keyup";
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.