Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpperCase for charcode #11

Merged
merged 1 commit into from Jun 30, 2013

Conversation

Projects
None yet
2 participants
@galedrag
Copy link
Contributor

commented Jun 24, 2013

UpperCase for charcode

Infocatcher added a commit that referenced this pull request Jun 30, 2013

@Infocatcher Infocatcher merged commit e413e96 into Infocatcher:master Jun 30, 2013

@Infocatcher

This comment has been minimized.

Copy link
Owner

commented Jun 30, 2013

Shift+c != C on your keyboard layout? Interesting.

Infocatcher added a commit that referenced this pull request Jun 30, 2013

@galedrag

This comment has been minimized.

Copy link
Contributor Author

commented Jul 1, 2013

Shift+c != C on your keyboard layout? Interesting.
Only when "caps lock" is pressed (Ctrl+Shift+c == c)

@galedrag

This comment has been minimized.

Copy link
Contributor Author

commented Jul 1, 2013

I guess this is also the case with others hotkey

@Infocatcher

This comment has been minimized.

Copy link
Owner

commented Jul 1, 2013

Only when "caps lock" is pressed (Ctrl+Shift+c == c)

Oh, I forgot about this.

I guess this is also the case with others hotkey

All other seems to works correctly: used e.keyCode == e.DOM_VK_XXX and String.fromCharCode(e.charCode).toUpperCase() == "I" for Ctrl+I/Ctrl+Shift+I

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.