Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real links, that looks like dummy, may be opened in current tab #1

Closed
Infocatcher opened this issue May 31, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@Infocatcher
Copy link
Owner

commented May 31, 2013

Reported here: https://addons.mozilla.org/addon/right-links/reviews/471454/
Testcase: https://picasaweb.google.com/102637044608602136429/SchwarzwaldBlackForestOrBlueMountains?noredirect=1 (thumbnails)

URLs looks like <a href="#123456789"> and linked anchors doesn't exists on the page.

So we can emulate Ctrl+left-click (instead of just left-click) on such links or add target="_blank" attribute.
This will be buggy for

<a href="#preview" onclick="window.open(location.href);">...</a>

But this code is wrong and should be

<a href="#preview" onclick="window.open(location.href); return false;">...</a>
@s0lution

This comment has been minimized.

Copy link

commented Jun 23, 2013

Thanks for the fix. But there's a problem now with closing tabs (at Picasa) opened with right click. I have to doubleclick on the X at the tab to close it. Or i have to click once into the content of the tab before i can click the X. Seems to be some "autofocus" problem?

@Infocatcher

This comment has been minimized.

Copy link
Owner Author

commented Jun 28, 2013

I have to doubleclick on the X at the tab to close it. Or i have to click once into the content of the tab before i can click the X.

Oh, I see.
But this is different bug (and this bug exists in previous version), so I created another ticket: #2.

@Infocatcher

This comment has been minimized.

Copy link
Owner Author

commented Jul 16, 2013

Oops, I accidentally deleted my post with link to test version, here is it's contents:

Test version: right_links-0.3.8.2pre-fx-sm.xpi (source).
Should work on Picasa pages, but may break something else...

Also now available new test version with workaround for not clickable tabs: #2 (comment).

@Infocatcher

This comment has been minimized.

Copy link
Owner Author

commented Aug 22, 2013

Seems to works fine for me, so I closed the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.