feat: Extract login logic #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirambd
requested changes
Nov 25, 2025
Member
sirambd
left a comment
sirambd
left a comment
There was a problem hiding this comment.
Don't forget to move all login module files into Auth
CrossAppLogin/Login/src/main/kotlin/com/infomaniak/core/crossapplogin/login/LoginUtils.kt
Outdated
Show resolved
Hide resolved
Auth/src/main/kotlin/com/infomaniak/core/auth/utils/LoginUtils.kt
Outdated
Show resolved
Hide resolved
Auth/src/main/kotlin/com/infomaniak/core/auth/utils/LoginUtils.kt
Outdated
Show resolved
Hide resolved
Auth/src/main/kotlin/com/infomaniak/core/auth/utils/LoginUtils.kt
Outdated
Show resolved
Hide resolved
Auth/src/main/kotlin/com/infomaniak/core/auth/utils/LoginUtils.kt
Outdated
Show resolved
Hide resolved
CrossAppLogin/Login/src/main/kotlin/com/infomaniak/core/crossapplogin/login/LoginUtils.kt
Outdated
Show resolved
Hide resolved
LunarX
force-pushed
the
extract-login-logic
branch
2 times, most recently
from
ebaeeb3 to
79f709a
Compare
tevincent
reviewed
Nov 27, 2025
Auth/src/main/kotlin/com/infomaniak/core/auth/utils/LoginUtils.kt
Outdated
Show resolved
Hide resolved
Auth/src/main/kotlin/com/infomaniak/core/auth/utils/LoginUtils.kt
Outdated
Show resolved
Hide resolved
Auth/src/main/kotlin/com/infomaniak/core/auth/utils/models/UserResult.kt
Outdated
Show resolved
Hide resolved
LouisCAD
previously requested changes
Nov 27, 2025
Auth/src/main/kotlin/com/infomaniak/core/auth/utils/LoginUtils.kt
Outdated
Show resolved
Hide resolved
tevincent
approved these changes
Nov 27, 2025
sirambd
requested changes
Nov 28, 2025
LunarX
force-pushed
the
extract-login-logic
branch
from
7bbec0f to
5ddec9a
Compare
|
sirambd
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factorize and share the login logic so we don't have to duplicated it in each app or even worse, multiple times in the same app.
the coed goes in the Auth module with all authentication related logic.
The code now avoids nested lambdas and returns results we can process at each step in order to have a more straight forward code