diff --git a/Mail/Views/Onboarding/OnboardingView.swift b/Mail/Views/Onboarding/OnboardingView.swift index 9204db7d4..467c144f1 100644 --- a/Mail/Views/Onboarding/OnboardingView.swift +++ b/Mail/Views/Onboarding/OnboardingView.swift @@ -254,7 +254,7 @@ struct OnboardingView: View { private let slides = Slide.onboardingSlides var body: some View { - WaveView(slides: slides, selectedSlide: $selectedSlide) { index in + WaveView(slides: slides, selectedSlide: $selectedSlide, dismissHandler: nil) { index in index == slides.count - 1 || (index == slides.count - 2 && selectedSlide == slides.count - 1) } bottomView: { _ in OnboardingBottomButtonsView( diff --git a/Mail/Views/Onboarding/SingleOnboardingView.swift b/Mail/Views/Onboarding/SingleOnboardingView.swift index 01e07989d..5a995e325 100644 --- a/Mail/Views/Onboarding/SingleOnboardingView.swift +++ b/Mail/Views/Onboarding/SingleOnboardingView.swift @@ -31,19 +31,13 @@ struct SingleOnboardingView: View { private let slides = [Slide.onboardingSlides.last!] var body: some View { - WaveView(slides: slides, selectedSlide: .constant(0)) { _ in + WaveView(slides: slides, selectedSlide: .constant(0), dismissHandler: dismiss.callAsFunction) { _ in OnboardingBottomButtonsView( selection: .constant(0), slideCount: 1 ) } .ignoresSafeArea() - .overlay(alignment: .topLeading) { - CloseButton(size: .regular, dismissAction: dismiss) - .padding(.top, UIPadding.onBoardingLogoTop) - .padding(.top, value: .verySmall) - .padding(.leading, value: .medium) - } .onAppear { if UIDevice.current.userInterfaceIdiom == .phone { UIDevice.current diff --git a/Mail/Views/Onboarding/WaveView.swift b/Mail/Views/Onboarding/WaveView.swift index bd3078cdd..fea13a1da 100644 --- a/Mail/Views/Onboarding/WaveView.swift +++ b/Mail/Views/Onboarding/WaveView.swift @@ -31,6 +31,8 @@ struct WaveView: UIViewControllerRepresentable { let slides: [Slide] let headerImage: UIImage? + let dismissHandler: (() -> Void)? + let shouldAnimateBottomViewForIndex: (Int) -> Bool @ViewBuilder var bottomView: (Int) -> BottomView @@ -39,6 +41,7 @@ struct WaveView: UIViewControllerRepresentable { selectedSlide: Binding, isScrollEnabled: Bool = true, headerImage: UIImage? = MailResourcesAsset.logoText.image, + dismissHandler: (() -> Void)? = nil, shouldAnimateBottomViewForIndex: @escaping (Int) -> Bool = { _ in return false }, @ViewBuilder bottomView: @escaping (Int) -> BottomView ) { @@ -46,6 +49,7 @@ struct WaveView: UIViewControllerRepresentable { self.headerImage = headerImage _selectedSlide = selectedSlide self.isScrollEnabled = isScrollEnabled + self.dismissHandler = dismissHandler self.shouldAnimateBottomViewForIndex = shouldAnimateBottomViewForIndex self.bottomView = bottomView } @@ -55,7 +59,8 @@ struct WaveView: UIViewControllerRepresentable { headerImage: headerImage, slides: slides, pageIndicatorColor: accentColor.primary.color, - isScrollEnabled: isScrollEnabled + isScrollEnabled: isScrollEnabled, + dismissHandler: dismissHandler ) let controller = OnboardingViewController(configuration: configuration) diff --git a/Package.resolved b/Package.resolved index 4e524c7f0..d8f5066c9 100644 --- a/Package.resolved +++ b/Package.resolved @@ -94,8 +94,8 @@ "kind" : "remoteSourceControl", "location" : "https://github.com/Infomaniak/ios-onboarding", "state" : { - "revision" : "581bf10b6bcbd7bb2331d844ed6d4030858e97d3", - "version" : "1.0.2" + "revision" : "93c65af1343a928bf63ac58cb06ace2f0170d264", + "version" : "1.0.3" } }, { diff --git a/Package.swift b/Package.swift index 31151ae5a..e540f88cb 100644 --- a/Package.swift +++ b/Package.swift @@ -27,7 +27,7 @@ let package = Package( .package(url: "https://github.com/Infomaniak/ios-create-account", .upToNextMajor(from: "8.0.0")), .package(url: "https://github.com/Infomaniak/ios-bug-tracker", .upToNextMajor(from: "5.0.0")), .package(url: "https://github.com/Infomaniak/ios-version-checker", .upToNextMajor(from: "5.0.0")), - .package(url: "https://github.com/Infomaniak/ios-onboarding", .upToNextMajor(from: "1.0.2")), + .package(url: "https://github.com/Infomaniak/ios-onboarding", .upToNextMajor(from: "1.0.3")), .package(url: "https://github.com/Infomaniak/swift-modal-presentation", .upToNextMajor(from: "1.0.0")), .package(url: "https://github.com/Infomaniak/SQRichTextEditor", .upToNextMajor(from: "1.1.2")), .package(url: "https://github.com/Infomaniak/SwiftSoup", .upToNextMajor(from: "1.1.0")),