From dcbadeaa27f6361907dbdb252e0c332a51ae73fd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adrien=20Coye=20de=20Brune=CC=81lis?= Date: Tue, 6 Jun 2023 14:27:44 +0200 Subject: [PATCH 1/2] feat: settings button with a nice touchable zone --- Mail/Views/Menu Drawer/MenuHeaderView.swift | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/Mail/Views/Menu Drawer/MenuHeaderView.swift b/Mail/Views/Menu Drawer/MenuHeaderView.swift index 96ae784ba..3c5510dfc 100644 --- a/Mail/Views/Menu Drawer/MenuHeaderView.swift +++ b/Mail/Views/Menu Drawer/MenuHeaderView.swift @@ -38,10 +38,13 @@ struct MenuHeaderView: View { Button { isShowingSettings.toggle() } label: { - MailResourcesAsset.cog.swiftUIImage - .resizable() - .scaledToFit() - .frame(width: 24) + // Some added padding around the asset for a nice touchable zone + VStack { + MailResourcesAsset.cog.swiftUIImage + .resizable() + .scaledToFit() + .frame(width: 24) + }.padding() } .buttonStyle(.borderless) .accessibilityLabel(MailResourcesStrings.Localizable.settingsTitle) From 82fd91d172744ccd0d303fc347b8543a43f5a533 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adrien=20Coye=20de=20Brune=CC=81lis?= Date: Tue, 6 Jun 2023 14:36:27 +0200 Subject: [PATCH 2/2] feat: cleaner solution --- Mail/Views/Menu Drawer/MenuHeaderView.swift | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/Mail/Views/Menu Drawer/MenuHeaderView.swift b/Mail/Views/Menu Drawer/MenuHeaderView.swift index 3c5510dfc..d3f94e3bf 100644 --- a/Mail/Views/Menu Drawer/MenuHeaderView.swift +++ b/Mail/Views/Menu Drawer/MenuHeaderView.swift @@ -38,13 +38,11 @@ struct MenuHeaderView: View { Button { isShowingSettings.toggle() } label: { - // Some added padding around the asset for a nice touchable zone - VStack { - MailResourcesAsset.cog.swiftUIImage - .resizable() - .scaledToFit() - .frame(width: 24) - }.padding() + MailResourcesAsset.cog.swiftUIImage + .resizable() + .scaledToFit() + .frame(width: 24) + .padding() // Some added padding for a nice touchable zone } .buttonStyle(.borderless) .accessibilityLabel(MailResourcesStrings.Localizable.settingsTitle)