Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorter SCSP behaviour review duration #4

Merged
merged 2 commits into from Nov 16, 2018

Conversation

Projects
None yet
2 participants
@GordonF42
Copy link
Member

commented Nov 2, 2018

Since we are early in development and there will be a lot of SCS for adding new features, which may also depend on other SCS. The current 2-week review duration will probably slow down a bit too much the initial development process.
The review duration will probably be restored to 2 weeks when the ground work is finished.

Note: Specs bot will need to be updated to display 7 days instead of 14 when this is merged.

@vabd
Copy link
Member

left a comment

On top of that, please expand each line to as close to 80 char as possible (while keeping it under or equal to this length) to keep the formatting consistent trough the whole documentation.

FTR this would turn the end of the file into:

total of 7 days (one week). During this period, anyone **can** issue a review on
the SCS or comment and discuss it, preferably in the pull request's comments.
Show resolved Hide resolved content/introduction/scsp.md Outdated
@GordonF42

This comment has been minimized.

Copy link
Member Author

commented Nov 2, 2018

my bad, should be good now

@vabd

vabd approved these changes Nov 3, 2018

Copy link
Member

left a comment

lgtm, let's wait till the end of the 14 day-long call for review before merging it

@vabd

This comment has been minimized.

Copy link
Member

commented Nov 16, 2018

Merging today. Might be worth noting that this new rule only applies for SCSs that have been open after the merging happens (the ones that have been open before that are still subject to the full 14 days rule).

@vabd vabd merged commit 0cd30cf into master Nov 16, 2018

@vabd vabd added scsp:merged and removed scsp:review labels Nov 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.