Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesn't work on Laravel 5.1 #238

Closed
janbolat opened this issue Jul 30, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@janbolat
Copy link
Contributor

commented Jul 30, 2016

Hello,

just installed your package, it seems it doesn't work on Laravel 5.1.
my composer.json:

 "infyomlabs/laravel-generator": "dev-master",
 "laravelcollective/html": "5.1.*",
 "infyomlabs/core-templates": "dev-master"

When I try to generate CRUD:

php artisan infyom:scaffold Bond

it returns me this error:

PHP Fatal error: Call to undefined method InfyOm\Generator\Commands\Scaffold\ScaffoldGeneratorCommand::hasOption() in /var/www/site/html/vendor/infyomlabs/laravel-generator/src/Common/GeneratorConfig.php on line 262

Apparently Laravel 5.1 doesn't have that method, but 5.2 does.

It seems you added this method 2 hours ago in 48c3889ef1d107c92b31960562e8bae2dafa9009

How can I make it work on 5.1?

@mitulgolakiya

This comment has been minimized.

Copy link
Member

commented Jul 31, 2016

@janbolat will fix it soon.

mitulgolakiya added a commit that referenced this issue Jul 31, 2016

@mitulgolakiya

This comment has been minimized.

Copy link
Member

commented Jul 31, 2016

@janbolat its fixed. checked with the latest version.

@janbolat

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2016

thanks, it works!

jschlies added a commit to jschlies/laravel-generator that referenced this issue Jun 17, 2017

InfyOmLabs#238 hasOption is not supported in 5.1
(cherry picked from commit eb9b0a7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.