Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fieldsFile example JSON needs to be updated #384

Closed
chellman opened this issue Feb 17, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@chellman
Copy link

commented Feb 17, 2017

At least that's what it seems like.

Checkboxes should be specified using htmlType: checkbox, not htmlType: checkbox:1. In src/Utils/HTMLFieldGenerator.php, there's a switch on $field->htmlType, which looks for 'checkbox' with no modifiers. When I use 'checkbox:1', the field is not added to the CRUD form, but when I use just 'checkbox', it is.

@mitulgolakiya

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

@chellman based on this guide, http://labs.infyom.com/laravelgenerator/docs/5.8/fields-input-guide, checkbox,1 is the expected value as input for the generator. not checkbox:1.

@chellman

This comment has been minimized.

Copy link
Author

commented Mar 14, 2019

This ticket is old, so I'm not 100% sure I was referring to, but I think it was this file:

https://github.com/InfyOmLabs/laravel-generator/blob/develop/samples/fields_sample.json#L83

"htmlType": "checkbox:1"

So it sounds like it should be this instead:

"htmlType": "checkbox,1"

Correct?

@ajayinfyom ajayinfyom self-assigned this Mar 15, 2019

ajayinfyom added a commit that referenced this issue Mar 15, 2019

@ajayinfyom ajayinfyom added in-progress and removed invalid labels Mar 15, 2019

mitulgolakiya added a commit that referenced this issue Mar 16, 2019

mitulgolakiya added a commit that referenced this issue Mar 16, 2019

mitulgolakiya added a commit that referenced this issue Mar 16, 2019

@mitulgolakiya

This comment has been minimized.

Copy link
Member

commented Mar 16, 2019

@chellman great catch. it's fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.