Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix when using fromTable option #364

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@amour0327
Copy link
Contributor

commented Dec 31, 2016

  1. not add checkbox in fields.blade.php when htmlType is boolean

$fieldTemplate is empty.
https://github.com/InfyOmLabs/laravel-generator/blob/5.2/src/Generators/Scaffold/ViewGenerator.php#L302

Because, $field->htmlType is not checkbox.
Example, $field->htmlType is boolean,hoge,1,

  1. not cast tinyint to boolean

tinyint cast to boolean when $field->fieldType is boolean.
https://github.com/InfyOmLabs/laravel-generator/blob/5.2/src/Generators/ModelGenerator.php#L230

But, $field->fieldType is bigInteger.
https://github.com/InfyOmLabs/laravel-generator/blob/5.2/src/Utils/TableFieldsGenerator.php#L89

@mitulgolakiya

This comment has been minimized.

Copy link
Member

commented Jan 5, 2017

@amour0327 Can you put this same pull request in develop branch?

@amour0327 amour0327 deleted the amour0327:bug_fix/fromTable branch Jan 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.