Skip to content

feat: Add notes about testnet proposal submission #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 21, 2024
Merged

feat: Add notes about testnet proposal submission #8

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13e3658
Merge pull request #6 from InjectiveLabs/dev
bangjelkoski Oct 8, 2024
fb3d860
Merge pull request #7 from InjectiveLabs/dev
bangjelkoski Oct 9, 2024
7b4903a
feat: Add info about testnet proposal submission
shibaeff Oct 11, 2024
5c58bba
feat: Improve info about testnet proposal submission
shibaeff Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/develop/cheat-sheet/index.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,12 @@ inj1qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqe2hm49

This is effectively the Injective `0x0...` address converted into `bech32`.

## Creating Proposals on Testnet

To successfully pass the proposal for testnet, `YOUR_DEPOSIT` should be slightly less than `min_deposit`
value (for example, `40000000000000000000inj`). After that you should contact the Injective dev team. Dev team will
top up your deposit to `min_deposit` and vote for your proposal.
Comment on lines +118 to +122
Copy link

@coderabbitai coderabbitai bot Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Enhance the new section on Creating Proposals on Testnet

Thank you for adding this new section and addressing the typo from the previous review. To further improve it:

  1. Consider expanding the content as suggested in the past review. Include steps to create a proposal, required parameters, and specific timeframes for Testnet proposals.

  2. Improve grammar and punctuation:

    • Add a comma after "After that" on line 121.
    • Consider rephrasing "To successfully pass the proposal for testnet" to "To submit a proposal on testnet".

  3. Enhance formatting for better readability:

    • Use bullet points or numbered steps for the process.
    • Highlight important values like YOUR_DEPOSIT and min_deposit using inline code formatting.

Here's a suggested revision:

## Creating Proposals on Testnet

To submit a proposal on testnet:

1. Set `YOUR_DEPOSIT` to be slightly less than the `min_deposit` value (e.g., `40000000000000000000inj`).
2. Submit your proposal transaction.
3. Contact the Injective dev team. They will:
   - Top up your deposit to reach `min_deposit`.
   - Vote on your proposal.

Note: Coordination with the Injective dev team is crucial for successfully passing proposals on testnet.

Would you like assistance in implementing these suggestions or expanding the content further?

🧰 Tools
🪛 LanguageTool

[typographical] ~121-~121: Consider adding a comma here.
Context: ...or example, 40000000000000000000inj). After that you should contact the Injective dev te...

(FOR_THAT_COMMA)


## Creating Transactions

### Via APIs
Expand Down