Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zpool): Integer overflow in zpool parser. #89

Merged
merged 2 commits into from Aug 25, 2019
Merged

Conversation

andoriyu
Copy link
Member

@andoriyu andoriyu commented Aug 25, 2019

Closes #88

Instead of crashing return std::u64::MAX

Closes #88
@codecov
Copy link

codecov bot commented Aug 25, 2019

Codecov Report

Merging #89 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   89.81%   89.84%   +0.03%     
==========================================
  Files           9        9              
  Lines        1374     1379       +5     
==========================================
+ Hits         1234     1239       +5     
  Misses        140      140
Impacted Files Coverage Δ
src/zpool/vdev.rs 98% <ø> (ø) ⬆️
src/zpool/description.rs 87.5% <100%> (ø) ⬆️
src/parsers/mod.rs 96.62% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 625cedb...9ac2eed. Read the comment docs.

@andoriyu andoriyu merged commit dd0da1b into master Aug 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the zpool/int_overflow branch August 25, 2019 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consumer should be able to create zfs data
1 participant