375-static-workbook-images #524
Conversation
marshmallowrobot
force-pushed
the
375-static-workbook-images
branch
from
4c0c903 to
a1c2b8d
Compare
marshmallowrobot
force-pushed
the
375-static-workbook-images
branch
from
a1c2b8d to
ff9f16e
Compare
|
Woah! Very excited to look at this! |
|
@rrrutledge and I walked through this PR together after today's Learning Path Meeting. We decided to favor consistency regarding the treatment of the images, at least for now. Like the other static images, the workbook images should live only in the website repository (innersourcecommons.org). They should not live in both repos and get copied from one to the other. I will update this PR to remove the static images and submit a sister PR in the other repository. |
marshmallowrobot
force-pushed
the
375-static-workbook-images
branch
from
ff9f16e to
9c33ad3
Compare
|
The sister-PR in innersourcecommons.org repository is ready for review! This PR is also ready for a second review! |
|
Thanks for these updates, @marshmallowrobot ❗️I’m excited to take a look. |
rrrutledge
left a comment
rrrutledge
left a comment
There was a problem hiding this comment.
Simple and consistent. Thank you
|
Looks like the companion PR is in. Let's do this. |
It's all new! and improved! haha
This PR includes an HTML image template, new static images, and a small change to section data JSON to get them included during site generation.
Please let me know your feedbacks! TY!
(This PR is tangentially related to a previously closed PR: #522)