Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to markdown files that were missing in README.md #136

Conversation

@spier
Copy link
Contributor

spier commented Mar 25, 2020

Improves issue reported in #135

This PR adds link to markdown files that were in this repo, but that were not linked from README.md.
While at it, I also fixed the template format of introducing-metrics-in-innersource.md.

Details:

  • .md files in this repo = 19
  • .md files linked from README.md = 15

Explanation for the difference in count:

  • README.md itself - not a problem
  • introducing-metrics-in-innersource.md - link added
  • junkyard-styled-innersourcing.md - link added
  • pattern-system.md - not sure what to do with this. maybe link from the # What are Inner Source Patterns? section in the README?
…ed from README.md. Also fixed template format of introducing-metrics-in-innersource.md.
@spier

This comment has been minimized.

Copy link
Contributor Author

spier commented Mar 25, 2020

Does anybody have an idea what to do with pattern-system.md? Should that be linked from the README?

@maxcapraro

This comment has been minimized.

Copy link
Member

maxcapraro commented Mar 26, 2020

Hi @spier. Thanks a lot for this contribution - and particularly also for the other contributions you made to improve this repo in the last days ❤️ Thank you!

The changes in this repo look good to me.

Does anybody have an idea what to do with pattern-system.md? Should that be linked from the README?

From what I understand, the pattern-system.md file does not yet include the one solution on how we could organize / classify / label the patterns - but rather multiple ideas / perspective. Still, I feel it's an important document to point people to.

Maybe we add it to the README.md with a disclaimer text like this?

For a human reader it is not easy to digest a loooooong list of patterns. We are working on labeling and classifying the patterns further. See pattern-system.md for our current thoughts!

@lenucksi

This comment has been minimized.

Copy link
Member

lenucksi commented Mar 26, 2020

For a human reader it is not easy to digest a loooooong list of patterns. We are working on labeling and classifying the patterns further. See pattern-system.md for our current thoughts!

I agree with what Max said and add that @maxcapraro could've turned the disclaimer into a commit suggestion ;)

…block. Including a disclaimer that this is a draft, as suggested by @maxcapraro
Copy link
Member

lenucksi left a comment

Thanks for adding & fixing this! LGTM

@lenucksi lenucksi merged commit ead08cd into InnerSourceCommons:master Mar 26, 2020
@maxcapraro

This comment has been minimized.

Copy link
Member

maxcapraro commented Mar 26, 2020

I agree with what Max said and add that @maxcapraro could've turned the disclaimer into a commit suggestion ;)

I agree with what Johannes said and solemly swear to do that next time 🙏

@spier spier deleted the spier:issues/135-link-to-missing-markdown-files branch Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.