Skip to content

Commit

Permalink
Rename DrawCallback.onDraw to prevent ClassLoader errors in AS designer
Browse files Browse the repository at this point in the history
  • Loading branch information
jfresen committed Feb 10, 2017
1 parent 3149b36 commit 59e4e4b
Show file tree
Hide file tree
Showing 21 changed files with 22 additions and 36 deletions.
Expand Up @@ -27,7 +27,7 @@ public FontChronometer(Context context, AttributeSet attrs, int defStyle) {

private final DrawCallback drawCallback = new DrawCallback() {
@SuppressLint("WrongCall")
@Override public void onDraw(Canvas canvas) {
@Override public void onDrawCall(Canvas canvas) {
FontChronometer.super.onDraw(canvas);
}
};
Expand Down
Expand Up @@ -29,7 +29,7 @@ public FontExtractEditText(Context context, AttributeSet attrs, int defStyle) {

private final DrawCallback drawCallback = new DrawCallback() {
@SuppressLint("WrongCall")
@Override public void onDraw(Canvas canvas) {
@Override public void onDrawCall(Canvas canvas) {
FontExtractEditText.super.onDraw(canvas);
}
};
Expand Down
2 changes: 1 addition & 1 deletion lib-core/src/main/java/com/innovattic/font/FontSwitch.java
Expand Up @@ -34,7 +34,7 @@ public FontSwitch(Context context, AttributeSet attrs, int defStyle) {

private final DrawCallback drawCallback = new DrawCallback() {
@SuppressLint("WrongCall")
@Override public void onDraw(Canvas canvas) {
@Override public void onDrawCall(Canvas canvas) {
FontSwitch.super.onDraw(canvas);
}
};
Expand Down
Expand Up @@ -27,7 +27,7 @@ public FontToggleButton(Context context, AttributeSet attrs, int defStyle) {

private final DrawCallback drawCallback = new DrawCallback() {
@SuppressLint("WrongCall")
@Override public void onDraw(Canvas canvas) {
@Override public void onDrawCall(Canvas canvas) {
FontToggleButton.super.onDraw(canvas);
}
};
Expand Down
18 changes: 2 additions & 16 deletions lib-core/src/main/java/com/innovattic/font/TypefaceManager.java
Expand Up @@ -569,28 +569,14 @@ public static void onDrawHelper(Canvas canvas, TextView target, DrawCallback dra
target.setTextColor(data.borderColor);
paint.setStyle(Paint.Style.STROKE);
paint.setStrokeWidth(data.borderWidth);
callDrawCallback(drawCallback, canvas);
drawCallback.onDrawCall(canvas);

target.setTextColor(oldTextColors);
paint.setStyle(oldStyle);
paint.setStrokeWidth(oldStrokeWidth);
}
}

/**
* Calls the draw callback with the given canvas. Use this method instead of calling it
* yourself, as lint is fooled by the method name 'onDraw' and thinks we are intervening with
* the render cycle. With this method, we can isolate the suppress lint annotation to the only
* warning we want to suppress.
*
* @param drawCallback
* @param canvas
*/
@SuppressLint("WrongCall")
private static void callDrawCallback(DrawCallback drawCallback, Canvas canvas) {
drawCallback.onDraw(canvas);
}

/**
* A data holder in which properties are stored that are not part of the default text view
* attributes, but which are applicable to all custom Font widgets. By storing this data holder
Expand Down Expand Up @@ -632,7 +618,7 @@ public static ExtraFontData getFontData(TextView target, boolean createIfMissing
}

public static interface DrawCallback {
public void onDraw(Canvas canvas);
public void onDrawCall(Canvas canvas);
}

}
Expand Up @@ -27,7 +27,7 @@ public AutoCompleteFontTextView(Context context, AttributeSet attrs, int defStyl

private final DrawCallback drawCallback = new DrawCallback() {
@SuppressLint("WrongCall")
@Override public void onDraw(Canvas canvas) {
@Override public void onDrawCall(Canvas canvas) {
AutoCompleteFontTextView.super.onDraw(canvas);
}
};
Expand Down
Expand Up @@ -27,7 +27,7 @@ public CheckedFontTextView(Context context, AttributeSet attrs, int defStyle) {

private final DrawCallback drawCallback = new DrawCallback() {
@SuppressLint("WrongCall")
@Override public void onDraw(Canvas canvas) {
@Override public void onDrawCall(Canvas canvas) {
CheckedFontTextView.super.onDraw(canvas);
}
};
Expand Down
Expand Up @@ -27,7 +27,7 @@ public FontButton(Context context, AttributeSet attrs, int defStyle) {

private final DrawCallback drawCallback = new DrawCallback() {
@SuppressLint("WrongCall")
@Override public void onDraw(Canvas canvas) {
@Override public void onDrawCall(Canvas canvas) {
FontButton.super.onDraw(canvas);
}
};
Expand Down
Expand Up @@ -27,7 +27,7 @@ public FontCheckBox(Context context, AttributeSet attrs, int defStyle) {

private final DrawCallback drawCallback = new DrawCallback() {
@SuppressLint("WrongCall")
@Override public void onDraw(Canvas canvas) {
@Override public void onDrawCall(Canvas canvas) {
FontCheckBox.super.onDraw(canvas);
}
};
Expand Down
Expand Up @@ -27,7 +27,7 @@ public FontEditText(Context context, AttributeSet attrs, int defStyle) {

private final DrawCallback drawCallback = new DrawCallback() {
@SuppressLint("WrongCall")
@Override public void onDraw(Canvas canvas) {
@Override public void onDrawCall(Canvas canvas) {
FontEditText.super.onDraw(canvas);
}
};
Expand Down
Expand Up @@ -27,7 +27,7 @@ public FontRadioButton(Context context, AttributeSet attrs, int defStyle) {

private final DrawCallback drawCallback = new DrawCallback() {
@SuppressLint("WrongCall")
@Override public void onDraw(Canvas canvas) {
@Override public void onDrawCall(Canvas canvas) {
FontRadioButton.super.onDraw(canvas);
}
};
Expand Down
Expand Up @@ -27,7 +27,7 @@ public FontTextView(Context context, AttributeSet attrs, int defStyle) {

private final DrawCallback drawCallback = new DrawCallback() {
@SuppressLint("WrongCall")
@Override public void onDraw(Canvas canvas) {
@Override public void onDrawCall(Canvas canvas) {
FontTextView.super.onDraw(canvas);
}
};
Expand Down
Expand Up @@ -27,7 +27,7 @@ public MultiAutoCompleteFontTextView(Context context, AttributeSet attrs, int de

private final DrawCallback drawCallback = new DrawCallback() {
@SuppressLint("WrongCall")
@Override public void onDraw(Canvas canvas) {
@Override public void onDrawCall(Canvas canvas) {
MultiAutoCompleteFontTextView.super.onDraw(canvas);
}
};
Expand Down
Expand Up @@ -27,7 +27,7 @@ public AutoCompleteFontTextView(Context context, AttributeSet attrs, int defStyl

private final DrawCallback drawCallback = new DrawCallback() {
@SuppressLint("WrongCall")
@Override public void onDraw(Canvas canvas) {
@Override public void onDrawCall(Canvas canvas) {
AutoCompleteFontTextView.super.onDraw(canvas);
}
};
Expand Down
Expand Up @@ -27,7 +27,7 @@ public CheckedFontTextView(Context context, AttributeSet attrs, int defStyle) {

private final DrawCallback drawCallback = new DrawCallback() {
@SuppressLint("WrongCall")
@Override public void onDraw(Canvas canvas) {
@Override public void onDrawCall(Canvas canvas) {
CheckedFontTextView.super.onDraw(canvas);
}
};
Expand Down
Expand Up @@ -27,7 +27,7 @@ public FontButton(Context context, AttributeSet attrs, int defStyle) {

private final DrawCallback drawCallback = new DrawCallback() {
@SuppressLint("WrongCall")
@Override public void onDraw(Canvas canvas) {
@Override public void onDrawCall(Canvas canvas) {
FontButton.super.onDraw(canvas);
}
};
Expand Down
Expand Up @@ -27,7 +27,7 @@ public FontCheckBox(Context context, AttributeSet attrs, int defStyle) {

private final DrawCallback drawCallback = new DrawCallback() {
@SuppressLint("WrongCall")
@Override public void onDraw(Canvas canvas) {
@Override public void onDrawCall(Canvas canvas) {
FontCheckBox.super.onDraw(canvas);
}
};
Expand Down
Expand Up @@ -27,7 +27,7 @@ public FontEditText(Context context, AttributeSet attrs, int defStyle) {

private final DrawCallback drawCallback = new DrawCallback() {
@SuppressLint("WrongCall")
@Override public void onDraw(Canvas canvas) {
@Override public void onDrawCall(Canvas canvas) {
FontEditText.super.onDraw(canvas);
}
};
Expand Down
Expand Up @@ -27,7 +27,7 @@ public FontRadioButton(Context context, AttributeSet attrs, int defStyle) {

private final DrawCallback drawCallback = new DrawCallback() {
@SuppressLint("WrongCall")
@Override public void onDraw(Canvas canvas) {
@Override public void onDrawCall(Canvas canvas) {
FontRadioButton.super.onDraw(canvas);
}
};
Expand Down
Expand Up @@ -27,7 +27,7 @@ public FontTextView(Context context, AttributeSet attrs, int defStyle) {

private final DrawCallback drawCallback = new DrawCallback() {
@SuppressLint("WrongCall")
@Override public void onDraw(Canvas canvas) {
@Override public void onDrawCall(Canvas canvas) {
FontTextView.super.onDraw(canvas);
}
};
Expand Down
Expand Up @@ -27,7 +27,7 @@ public MultiAutoCompleteFontTextView(Context context, AttributeSet attrs, int de

private final DrawCallback drawCallback = new DrawCallback() {
@SuppressLint("WrongCall")
@Override public void onDraw(Canvas canvas) {
@Override public void onDrawCall(Canvas canvas) {
MultiAutoCompleteFontTextView.super.onDraw(canvas);
}
};
Expand Down

0 comments on commit 59e4e4b

Please sign in to comment.