From 6a5dd7a55bd3a145507951ca3db7a0d9fa55b924 Mon Sep 17 00:00:00 2001 From: A Dropboxer Date: Wed, 26 Feb 2020 07:26:21 +0000 Subject: [PATCH 1/2] test --- .../kairosdb/HistogramDatapointImplTest.java | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 src/test/java/io/inscopemetrics/kairosdb/HistogramDatapointImplTest.java diff --git a/src/test/java/io/inscopemetrics/kairosdb/HistogramDatapointImplTest.java b/src/test/java/io/inscopemetrics/kairosdb/HistogramDatapointImplTest.java new file mode 100644 index 0000000..d43a324 --- /dev/null +++ b/src/test/java/io/inscopemetrics/kairosdb/HistogramDatapointImplTest.java @@ -0,0 +1,19 @@ +package io.inscopemetrics.kairosdb; + +import org.junit.Assert; +import org.junit.Test; + +import java.util.TreeMap; + +public class HistogramDatapointImplTest { + @Test + public void testLargeSampleCount() { + final TreeMap map = new TreeMap<>(); + map.put(1d, 2147483647); + map.put(2d, 2147483647); + map.put(3d, 2147483647); + map.put(4d, 2147483647); + final HistogramDataPointImpl dp = new HistogramDataPointImpl(1, map, -10, 10, 10, 10); + Assert.assertEquals(8589934588L, dp.getSampleCount()); + } +} From 115852891cf13f20fabdb38b448a0045d108d266 Mon Sep 17 00:00:00 2001 From: A Dropboxer Date: Wed, 26 Feb 2020 07:27:34 +0000 Subject: [PATCH 2/2] actually fix --- .../java/io/inscopemetrics/kairosdb/HistogramDataPointImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/io/inscopemetrics/kairosdb/HistogramDataPointImpl.java b/src/main/java/io/inscopemetrics/kairosdb/HistogramDataPointImpl.java index 085eb30..d773a01 100644 --- a/src/main/java/io/inscopemetrics/kairosdb/HistogramDataPointImpl.java +++ b/src/main/java/io/inscopemetrics/kairosdb/HistogramDataPointImpl.java @@ -233,7 +233,7 @@ public long getOriginalCount() { */ @Override public long getSampleCount() { - int count = 0; + long count = 0; for (Integer binSamples : map.values()) { count += binSamples; }