Add namespace metadata #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Labels have too much restrictions on what they can contain (both on key and values) so let's use annotations instead |
github-actions
bot
added
the
documentation
|
This PR is up for review, feedback is welcome |
olevitt
added
enhancement
micedre
approved these changes
Jun 10, 2024
github-actions
bot
added
the
documentation
github-actions
bot
added
the
documentation
|
There is currently a regression on events as each onboarding call will trigger a |
|
I ve tested the MR on the main scenario seems to work for me |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds user metadata to the namespace at each onboard (see InseeFrLab/onyxia#752).
The list of claims to be added is configurable at region's level.
This is in addition to the already existing support for static labels & static annotations.