Skip to content

Conversation

@joaocarvoli
Copy link
Contributor

@joaocarvoli joaocarvoli commented May 27, 2021

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project (see .code-style.md).
  • All new and existing tests passed (see .testing.md).
  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly (see .documentation.md).

Description

  • What is the current behavior? (You can also link to an open issue here)
    In this pull, I added examples of each function in the trajectories module.

@joaocarvoli joaocarvoli requested a review from mxaviersmp May 27, 2021 21:25
2 39.984224 116.319402 2008-10-23 05:53:11 1 {'c': 3}
3 39.984211 116.319389 2008-10-23 05:53:16 1 {'d': 4}
4 39.984217 116.319422 2008-10-23 05:53:21 1 {'e': 5}
>>> flatten_columns(moveDf, columns = 'dict_column')
Copy link
Contributor

@mxaviersmp mxaviersmp May 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrigir o nome move_df, remover os espaços entre o =

Olha com esse exemplo:

d1 = {'a': 1, 'b': 2}
d2 = {'a': 3, 'c': 4}

df = pd.DataFrame({'col1': [1, 2], 'col2': [d1, d2]})
flatten_columns(df, 'col2')

Comment on lines 145 to 147
>>> from pymove.utils.trajectories import flatten_dict
>>> d = {'a': 1, 'b': {'c': 2, 'd': 3}}
>>> flatten_dict(traj_dict, 'x')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Não precisa colocar esse 'x'

@mxaviersmp mxaviersmp merged commit b19b7c0 into developer May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants