From d5beb7a657e0a84043503addab2ba1ac38aa2214 Mon Sep 17 00:00:00 2001 From: Niels Dekker Date: Thu, 17 Nov 2022 13:34:50 +0100 Subject: [PATCH] STYLE: NumberToStringGTest: add #include, avoid narrowing conversion pow Added `#include `, to ensure that all `std::pow` overloads are included. Explicitly declared the local `power_of_ten` variables as `TValue` and prevented a narrowing conversion from those `std::pow` calls, just to be sure. --- Modules/Core/Common/test/itkNumberToStringGTest.cxx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Modules/Core/Common/test/itkNumberToStringGTest.cxx b/Modules/Core/Common/test/itkNumberToStringGTest.cxx index 03c64d9fd9a..57003e58ca0 100644 --- a/Modules/Core/Common/test/itkNumberToStringGTest.cxx +++ b/Modules/Core/Common/test/itkNumberToStringGTest.cxx @@ -19,6 +19,7 @@ // First include the header file to be tested: #include "itkNumberToString.h" #include +#include // For std::pow. namespace { @@ -81,7 +82,7 @@ Test_decimal_notation_supports_up_to_twentyone_digits() for (int8_t exponent{ 20 }; exponent > 0; --exponent) { - const auto power_of_ten = std::pow(TValue{ 10 }, static_cast(exponent)); + const TValue power_of_ten{ std::pow(TValue{ 10 }, static_cast(exponent)) }; // Test +/- 10 ^ exponent EXPECT_EQ(numberToString(power_of_ten), '1' + std::string(exponent, '0')); @@ -90,7 +91,7 @@ Test_decimal_notation_supports_up_to_twentyone_digits() for (int8_t exponent{ -6 }; exponent < 0; ++exponent) { - const auto power_of_ten = std::pow(TValue{ 10 }, static_cast(exponent)); + const TValue power_of_ten{ std::pow(TValue{ 10 }, static_cast(exponent)) }; // Test +/- 10 ^ exponent EXPECT_EQ(numberToString(power_of_ten), "0." + std::string(-1 - exponent, '0') + '1');