Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong output when resampling with Gaussian interpolation when employing streaming #1011

Open
romangrothausmann opened this issue Jun 12, 2019 · 5 comments

Comments

Projects
None yet
3 participants
@romangrothausmann
Copy link
Contributor

commented Jun 12, 2019

Description

Since #988 was resolved with #998, it is now possible to resample with Gaussian interpolation when employing streaming, but the output differs from the result when streaming is not used.

Steps to Reproduce

Based on the (apparent) MWE from #998 (comment), I tried to reproduce the problems found with my resamlple ITK-CLI:
https://gitlab.com/romangrothausmann/ITK-CLIs/commits/debugGaussRes

It turns out that when the streaming and the non-streaming are scoped (romangrothausmann/ITK-CLIs@eb81cb5), the resulting outputs (RAW from MHD) differ to each other but have the same MD5 as obtained with resamlple.

Expected behavior

The output from the resample filter should be the same no matter if streaming is used or not , this should hold for all available interpolators.

Versions

ITK @ 8d9f21d (#988)

Environment

DF from ITK-CLIs:
https://gitlab.com/romangrothausmann/ITK-CLIs/blob/eb81cb5ea63d3ac4edf0a97471ae776b129b0dee/Dockerfile

@romangrothausmann

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

@dzenanz @blowekamp
Not sure though why the version without scoping behaves differently. Could it be that the filter is not re-executed even though it has filter->ReleaseDataFlagOn();? Without that it would be necessary to outdate the filter (with input->Modified();) to have it re-execute for the streaming.

@romangrothausmann

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

@romangrothausmann

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

Minimal modification of the test program to reproduce the problem is just to write once per call using an extra parameter to define streaming or not: romangrothausmann/ITK-CLIs@b5cfc69

@dzenanz

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

@thewtex can you tackle this? test.cxx is an easy way to reproduce the problem.

@thewtex thewtex self-assigned this Jun 20, 2019

@thewtex

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

Yes, I will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.