Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize PointSetToPointSetMetricv4 #1144

Open
dzenanz opened this issue Aug 7, 2019 · 2 comments

Comments

@dzenanz
Copy link
Member

commented Aug 7, 2019

This was already done by 687c491, but had to be reverted by #1139 because #1138 did not fix sporadic failures #1131.

@dzenanz

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

I created this issue so we don't forget about it. @thewtex @hjmjohnson @samuelgerber

@samuelgerber

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

So I don't forget what I tried to fix it:

  1. derivative size is wrong at 687c491#r34604258
    but this was not the issue.
  2. It appeared that running it with only one thread fixed the issue (need to double check). Some concurrency issue somewhere?
  3. Tested if m_VirtualTransformedPointSet is updated concurrently and thread has wrong address to invalid array. I.e. the update checks might be incorrect when resetting the point sets etc. of the metric.
  4. Tried to store derivative field individually per thread and sum after into derivative.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.