Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eigen warnings with GCC 4.8.5 #1254

Open
SimonRit opened this issue Sep 16, 2019 · 6 comments · May be fixed by #1262

Comments

@SimonRit
Copy link

commented Sep 16, 2019

I have a bunch of shadow warnings when compiling with GCC 4.8.5, see
RTK dashoard. I am willing to fix them but I'm not sure what's the best procedure. Since they are coming from a third party software, Eigen3, should I add a rule in CMake/CTestCustom.cmake.in to ignore them or try to correct the Eigen3 code?

@dzenanz

This comment has been minimized.

Copy link
Member

commented Sep 18, 2019

Perhaps one way is to keep updating Eigen. @phcerdan integrated it first, if you look at his PRs you will find more details about it. As Eigen is a third-party library, another possibility is to suppress the warnings in that library (as you suggest).

@SimonRit

This comment has been minimized.

Copy link
Author

commented Sep 19, 2019

Thanks for your answer. As far as I can tell, the current HEAD of Eigen would not solve the warnings. One solution is to make a PR to Eigen but that's too much work for me. If you're ok, I'll make an ITK PR with the warning suppression.

@phcerdan

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2019

Hi Simon, open the PR to the Eigen fork for ITK and I can contribute it to proper Eigen if that overhead sets you back.

@phcerdan

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2019

Gcc 4.8 is getting really old though, not sure if its worth more work around it.

@dzenanz

This comment has been minimized.

Copy link
Member

commented Sep 20, 2019

A PR with suppression is welcome.

@SimonRit SimonRit referenced a pull request that will close this issue Sep 20, 2019
8 of 8 tasks complete
@SimonRit

This comment has been minimized.

Copy link
Author

commented Sep 20, 2019

Sorry for the delay, I was traveling. I wasn't sure what was the conclusion so I tried @phcerdan first suggestion (before commenting on the age of GCC 4.8). I'm aware the patch is not the nicest with parameters becoming meaningless but I don't know how to call them. I don't mind adding a line to CMake/CTestCustom.cmake.in if it's preferable or changing it after better suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.