New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update migration guide with Hough transform changes #136

Open
dzenanz opened this Issue Nov 6, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@dzenanz
Member

dzenanz commented Nov 6, 2018

typedef itk::HoughTransform2DCirclesImageFilter<ImageProcessingConstants::DefaultPixelType, ImageProcessingConstants::FloatPixelType> HoughTransformFilterType; now fails to compile:

47>c:\misc\bluequartz\dream3d_plugins\imageprocessing\imageprocessingfilters\itkhoughcircles.cpp(193): error C2976: 'itk::HoughTransform2DCirclesImageFilter': too few template arguments

A sentence or two about reasoning, and a suggested solution should be added to Class changes section of the migration guide.

@N-Dekker

This comment has been minimized.

Contributor

N-Dekker commented Nov 6, 2018

@dzenanz OK, I'll add a line or two on this topic to the migration guide.

By the way, this is the related commit:
06afe0f#diff-cd71664328a9fe41ea4b2c144e7ea9e5

@N-Dekker

This comment has been minimized.

Contributor

N-Dekker commented Nov 8, 2018

@dzenanz What about this one?

With ITK 5.0, HoughTransform2DCirclesImageFilter<TInputPixelType, TOutputPixelType, TRadiusPixelType> no longer has a default argument for its last template parameter. Instead, users of the filter should now explicitly specify all three template arguments. Earlier versions of ITK assumed TRadiusPixelType to be equal to TOutputPixelType, but it appears that for TRadiusPixelType, a floating point type is often preferred, whereas for TOutputPixelType, an unsigned integer type is often more appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment