Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Hypersensitive "Non unform sampling or missing slices detected" warning #1607
ITK's new non-uniform "sampling" detection (actually, slice spacing) is so sensitive that it is useless. It also generates so many warnings that it floods the log and slows down DICOM loading.
WARNING: In c:\d\s42d\itk\modules\io\imagebase\include\itkImageSeriesReader.hxx, line 440
The compared values are 0.29999999999999716 and 0.29999999999999999 (absolute difference is 2.8310687127941492e-15).
Steps to Reproduce
Load any DICOM series - but to give a specific example:
Only give a warning when spacing variation is non-negligible.
If the difference is magnitudes lower then the expected slice spacing then I definitely don't want to see any warning and don't want the image to be considered as having varying slice spacing.
A warning is logged for each slice.
Latest ITK 5.0.1rc01
I use the latest release candidate (ITK v5.1-rc01), which does not have this yet.
I've cherry-picked the content of #1476 but it did not help much. It still pollutes the log with hundreds of these messages (but at least it now shows the "deviation", too):
WARNING: In c:\d\s42rdi\itk\modules\io\imagebase\include\itkImageSeriesReader.hxx, line 444
Things that still need to be fixed: