New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and provide infrastructure for submitting patches to a branch other than master #180

Closed
thewtex opened this Issue Nov 14, 2018 · 1 comment

Comments

Projects
1 participant
@thewtex
Member

thewtex commented Nov 14, 2018

Document the process for getting a branch merged into release or release-4.13 in addition to master.

  • Add instructions to CONTRIBUTING.md for branching from a different branch.
  • Document submitting and merging to master first so it can be tested on the Nightly dashboard builds.
  • Add support to the git review-push for creating a PR to a different branch. This should also check that the topic was branched from the target branch.
@thewtex

This comment has been minimized.

Member

thewtex commented Dec 14, 2018

After further consideration, removing:

and by convention use a topic name starting in release-:

from CONTRIBUTING.md will be sufficient. Other steps can be taken by maintainers without cluttering the main documentation.

@thewtex thewtex moved this from To do to In progress in ITK v5.0b02 Dec 14, 2018

@thewtex thewtex closed this in #309 Dec 15, 2018

@thewtex thewtex moved this from In progress to Done in ITK v5.0b02 Dec 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment