New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to newest version of GDCM #284

Open
hjmjohnson opened this Issue Dec 8, 2018 · 2 comments

Comments

3 participants
@hjmjohnson
Copy link
Member

hjmjohnson commented Dec 8, 2018

GDCM has been updated recently to address forward compatibility issues with cmake.

The ITKv5Migration scripts were applied and accepted to the GDCM build tree, so cleaner ITK compatible codebase is available.

Performance improvements were added to GDCM.

LTO build now succeeds cleanly with newest GDCM.

@hjmjohnson hjmjohnson created this issue from a note in ITK 5.1.0 Public Release (To do) Dec 8, 2018

@hjmjohnson hjmjohnson added this to Low priority in Bug Triage Ordering Test Dec 8, 2018

@dzenanz

This comment has been minimized.

Copy link
Member

dzenanz commented Dec 8, 2018

We just wait for a release and then run UpdateFromUpstream.sh script?

@hjmjohnson

This comment has been minimized.

Copy link
Member

hjmjohnson commented Dec 8, 2018

@dzenanz yes. @malaterre merged some of this into the release branch on Thursday to provide better support for LTO, and I think he stated that they were working on a public tagged release soon (v3.0.0).

The final items needed for better/cleaner ITKv5 builds (more support for LTO with GDCM, and a requirement of GDCM 3.0.0) are still only available on the master branch.

There is not a critical need for this immediately, but hopefully, GDCM will be ready for inclusion in ITKv5 for the next beta release (December 18th ??).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment