Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeshIO classes Write methods fail/timeout and round-trip test fail #3455

Open
jhlegarreta opened this issue Jun 1, 2022 · 2 comments
Open
Labels
type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances

Comments

@jhlegarreta
Copy link
Member

Description

Some of the MeshIO (Modules/IO/Mesh*) classes Write* methods fail/timeout or the round-trip (write data, read back and compare the read values to the expected ones) fail.

Steps to Reproduce

The failing tests are located in the test module of each Modules/IO/Mesh* module. The failing calls have been commented out in the tests and a FIXME tag was put in the comments while adding the tests for these classes in #3403.

Expected behavior

Write methods work; tests do not timeout; round-trip checks pass.

Actual behavior

Some of the write methods do not work; tests timeout (MeshBYU); round-trip checks do not pass.

Reproducibility

%100.

Versions

master.

Environment

Issues were being reported in all platforms used by the CI builds. However, tests were passing on a Windows 7, MSVC 2019 machine.

Additional Information

Cross-referencing #3403 (comment)

Slightly related to this is the need to improve the buffer allocation method/buffer deletion, as noted in the referenced comment.

@jhlegarreta jhlegarreta added the type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances label Jun 1, 2022
@jhlegarreta
Copy link
Member Author

The buffer allocation/de-allocation method introduced memory leaks 😒:
https://open.cdash.org/viewDynamicAnalysis.php?buildid=7954824

I will push a WIP PR so that if @blowekamp or anyone that is able to run Valgrind on the branch and has the bandwidth can confirm whether the fix removes the leaks from the target test.

@jhlegarreta
Copy link
Member Author

I will push a WIP PR so that if @blowekamp or anyone that is able to run Valgrind on the branch and has the bandwidth can confirm whether the fix removes the leaks from the target test.

PR #3459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances
Projects
None yet
Development

No branches or pull requests

1 participant