New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document LabelObject perimeter computations #470

Open
blowekamp opened this Issue Feb 5, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@blowekamp
Copy link
Member

blowekamp commented Feb 5, 2019

Update documentation to include a link to the IJ paper:
http://hdl.handle.net/10380/3342

@jhlegarreta

This comment has been minimized.

Copy link
Member

jhlegarreta commented Feb 6, 2019

Thanks Brad. AFAIK the classes are not present in the toolkit: may be the code should be made into a remote module? I could help with that if necessary.

@blowekamp

This comment has been minimized.

Copy link
Member Author

blowekamp commented Feb 6, 2019

The LabelMap framework is in ITK as a Group:
https://github.com/InsightSoftwareConsortium/ITK/tree/master/Modules/Filtering/LabelMap/include

Thanks for offering to help. These classes do need a bit of improvement with documentation. The the data is stored in the objects derived from LabelObject i.e. ShapeLableObject, then there are separate filters which compute the data/attributes i.e. ShapeLabelMapFilter. Also there the filters are re-used in multiple other filters i.e. LabelImageToShapeLabelMapFilter. So it has never been clear where documentation of what the attributes mean and how they are computed should be located.

@jhlegarreta

This comment has been minimized.

Copy link
Member

jhlegarreta commented Feb 8, 2019

@blowekamp 👍 I thought that the classes having to do with the perimeter computation had not been included, but I've just seen that they're in the itk::ShapeLabelMapFilter class. Given that I'm not a heavy user of these classes, I'll just be open to help whenever you request so/when tasks can be split into clearer subtasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment